Add a [-] option to constants from arrays in the configuration#171
Merged
michael-schwarz merged 2 commits intomasterfrom Mar 18, 2021
Merged
Add a [-] option to constants from arrays in the configuration#171michael-schwarz merged 2 commits intomasterfrom
michael-schwarz merged 2 commits intomasterfrom
Conversation
sim642
requested changes
Mar 17, 2021
Member
sim642
left a comment
There was a problem hiding this comment.
It's a nice feature that can be used to clean up PARAMs of our regression tests. Instead of having a regression test respecify all analyses except one, it can now just disable one. Changing default analyses would be tremendously easier compared to fixing all regression tests like we did for mallocWrapper, threadflag and threadid.
sim642
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, we had a [+] option to add a constant to the arrays in the configuration. For example to add an extra analysis to the default array of active analyses for a specific regression test.
An option to remove a constant from an array would also be useful, so it's suggested by this pull request. It would be used like this:
// PARAM: --set ana.activated[-] "'mallocWrapper'"