Merged
Conversation
7 tasks
Member
This PR is marked as a precision improvement, but why isn't this a soundness matter? |
sim642
reviewed
Jan 6, 2025
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
Member
Author
It in fact is. I added another regression test for which master currently is unsound. |
sim642
approved these changes
Jan 14, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-creates #1555 but targeting master this time.
Currently,
LMustis unclustered even when clusters are employed. This leads to precision loss compared to the unclustered variant when:afor some clusters onlyais added toLMustlock(a),V.mutex_initsis not consulted for any cluster, asais inLMustHowever,
V.mutex_initsshould still be consulted for clusters that have not been published yet.This also clusters
LMustand adds a regression test for this behavior.c.f. #1551