Replace part_access transfer function with PartAccess query#162
Merged
Replace part_access transfer function with PartAccess query#162
Conversation
Mutex analysis does all the access handling anyway, so might as well be directly there.
Based on Vesal's addition in traces branch. Co-authored-by: Vesal Vojdani <vesal.vojdani@gmail.com>
Member
|
LGTM! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
part_accesstransfer function withPartAccessquery.This simplifies the
Specsignature and allows removing dummypart_accessimplementations fromSpeclifting functors. Especially as anything outside ofMCP2doesn't influence access partitioning anyway. Themeetof the new query result is chosen to coincide with the oldpart_accesscombination logic inMCP2, giving exactly the same behavior.MCP2.It doesn't need to be there at all and mutex analysis is a suitable place for it anyway, considering it is the one to invoke the
Accessqueries in the first place.Accessquery.Since mutex analysis can directly partition accesses using
PartAccessquery, theAccessquery, which was previously used to signalMCP2, is now unnecessary.It could be also argued that the whole accessing logic doesn't really belong to mutex analysis either and could be extracted out to a separate analysis, but I thought I won't go that far immediately.