Fix sem.unknown_function.spawn handling in base#1603
Merged
Conversation
1 task
michael-schwarz
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #1029 is done for a while, we can remove a hack in base whereby
sem.unknown_function.spawndidn't just apply to unknown functions (like it was supposed to), but all library functions with spawning arguments as well.The consequence is that
atexitneeds a separate option as planned by #1174 (comment).This requires some generalization of the library function DSL to allow options to control the argument access of a library function.
This makes us also more sound in SV-COMP where there are some instances of
atexitthat we currently completely ignored. Betteratexithandling is the goal of #799.