Union: meet in Field: Do not raise Uncomparable when one arg is Top#1471
Merged
michael-schwarz merged 2 commits intomasterfrom May 21, 2024
Merged
Union: meet in Field: Do not raise Uncomparable when one arg is Top#1471michael-schwarz merged 2 commits intomasterfrom
meet in Field: Do not raise Uncomparable when one arg is Top#1471michael-schwarz merged 2 commits intomasterfrom
Conversation
7 tasks
sim642
reviewed
May 20, 2024
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
sim642
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior leads to unnecessary imprecision in combination with the invariant refinement for privatizations at branches.
This was added in #1109 but it seems we were a bit overzealous in raising this exception even if one of the arguments is
Top.This fixes some of the issues described in #1456.