Closed
Conversation
5 tasks
Member
This is under the assumption that the same behavior can be achieved there, which is not a given, e.g., vis-a-vis automatic detection of widening points or the termination analysis. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is cherry-picked from #1372 in preparation for it to get merged: #1372 (comment).
I benchmarked the equivalent change at be3ee1d: https://goblint.cs.ut.ee/results/158-rm-loop-unroll-after/table-generator-cmp.diff.html. This costs us ~100 tasks, mostly from nla-digbench-scaling/_unwindbound and product-lines/elevator_spec.
The actual delta is that we lose ~130 true verdicts, but also gain ~30 true verdicts (from cases where unrolling causes excessive resource usage).
The nightly BenchExec run will give a more up-to-date comparison, but I don't expect it to be different since nothing notable has been changed in SV-COMP analyses in this time.
To get this back, we'll have to finalize #1370 for SV-COMP 2025.