Conversation
michael-schwarz
approved these changes
Feb 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks some commits from #847, but uses
graph-easyto visualize the.dotoutput instead of testing the Graphviz code directly.For end-to-end YAML witness location testing, #1357 is what we finally want, it's not super convenient and general to have to check for node locations through YAML witnesses. This is slightly more direct by both testing the CFG structure (which we've had problems about) and all node locations simultaneously.
TODO
__goblint_dummy_init, at least in these tests.main, which is orthogonal to the test.compute_cfgmove gobview#41).