Skip to content

Malloc wrappers#132

Merged
ivanazuzic merged 22 commits intomasterfrom
malloc_wrappers
Nov 16, 2020
Merged

Malloc wrappers#132
ivanazuzic merged 22 commits intomasterfrom
malloc_wrappers

Conversation

@ivanazuzic
Copy link
Copy Markdown
Contributor

@ivanazuzic ivanazuzic commented Nov 10, 2020

This should fix #123:

  • A new mallocWrapper analysis is created for the purpose of handling malloc calls wrapped inside other functions
  • The malloc wrapper analysis is now called from base analysis for calloc and malloc
  • Hash table for heap variables was moved from base analysis to mallocWrapper analysis
  • The functions which are interesting as malloc wrappers are stored in a configurable list exp.malloc.wrappers

@sim642 sim642 added feature sv-comp SV-COMP (analyses, results), witnesses labels Nov 10, 2020
@sim642 sim642 self-requested a review November 10, 2020 17:43
michael-schwarz
michael-schwarz reviewed Nov 10, 2020
View reviewed changes
michael-schwarz
michael-schwarz reviewed Nov 10, 2020
View reviewed changes
michael-schwarz
michael-schwarz reviewed Nov 10, 2020
View reviewed changes
michael-schwarz
michael-schwarz reviewed Nov 10, 2020
View reviewed changes
sim642
sim642 reviewed Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as it should.

I'm now mostly wondering what's the best way to put together a good malloc wrapper functions list for SV-COMP. There were a couple names in a benchmark that originally lead to this issue here: #123 (comment). Since the LDV benchmarks there seem to have similar framework (e.g ldv_malloc), then looking at some manually to be sure might be enough. It's very hard to be sure though.

sim642
sim642 reviewed Nov 11, 2020
View reviewed changes
@michael-schwarz michael-schwarz mentioned this pull request Nov 12, 2020
Closed
michael-schwarz
michael-schwarz reviewed Nov 12, 2020
View reviewed changes
michael-schwarz
michael-schwarz reviewed Nov 12, 2020
View reviewed changes
michael-schwarz
michael-schwarz reviewed Nov 12, 2020
View reviewed changes
michael-schwarz
michael-schwarz reviewed Nov 12, 2020
View reviewed changes
@michael-schwarz
Copy link
Copy Markdown
Member

michael-schwarz commented Nov 12, 2020

LGTM!

sim642
sim642 reviewed Nov 12, 2020
View reviewed changes
@sim642
Copy link
Copy Markdown
Member

sim642 commented Nov 16, 2020

I suppose this can be merged now?

@ivanazuzic ivanazuzic merged commit 71f78b3 into master Nov 16, 2020
@ivanazuzic ivanazuzic deleted the malloc_wrappers branch November 16, 2020 12:19
@sim642 sim642 added this to the SV-COMP 2021 milestone Nov 27, 2020
@ivanazuzic ivanazuzic restored the malloc_wrappers branch March 8, 2021 00:08
@sim642 sim642 deleted the malloc_wrappers branch April 15, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sim642 sim642 sim642 left review comments

@michael-schwarz michael-schwarz michael-schwarz left review comments

Assignees

No one assigned

Labels

feature sv-comp SV-COMP (analyses, results), witnesses

Projects

None yet

Milestone

SV-COMP 2021

Development

Successfully merging this pull request may close these issues.

Better handling of calls to malloc wrapped inside functions such as ldv_malloc

3 participants

@ivanazuzic @michael-schwarz @sim642