Fix region analysis unsoundness on three regression tests#106
Merged
vesalvojdani merged 5 commits intomasterfrom Oct 2, 2020
Merged
Fix region analysis unsoundness on three regression tests#106vesalvojdani merged 5 commits intomasterfrom
vesalvojdani merged 5 commits intomasterfrom
Conversation
Member
Author
|
On SV-COMP's SoftwareSystems-DeviceDriversLinux64-ReachSafety, universally enabling region (with offsets), var_eq and symb_locks after these fixes didn't have any unintended consequences. No additional unsoundness appeared (within 60s time limit). In 31 cases a previous timeout/error turned into a correct answer and in 10 cases a previous correct answer turned into a timeout, which isn't too surprising given the extra analyses. |
Member
|
This is necessary to merge, but could you create a low-priority ticket to document some underlying issues that need some further investigation. I can recall the following:
Was there anything else that was confusing? |
12 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following regression tests (with copies using new
PARAM):