-
Notifications
You must be signed in to change notification settings - Fork 87
Configuration of access collecting precision and performance #571
Copy link
Copy link
Closed
Labels
Milestone
Description
The following table gives an overview of producing race warnings for ypbind_comb from bench:
| Optimization | Race warning time |
|---|---|
| Baseline (#551, d2a50c5) | 1.822s |
| Access (def70a2) | 0.917s |
| MCP (#570) | 0.728s |
| Exclude MHP | 0.420s |
| Exclude node | 0.258s |
| Exclude MHP and node | 0.104s |
This confirms that the MHP component for collected accesses can have a significant performance impact on race warnings. The reason is that for each access location it can create many more accesses based on the thread ID and especially the created threads set. So in large programs with many variables and accesses, this has the measurable impact from above.
Therefore it might be useful to be able to dynamically (de)activate what information is collected for accesses to trade off between precision and performance. If on these programs MHP doesn't really rule out races, then for interactive benchmarking it would be beneficial to disable it and save time.
Reactions are currently unavailable