Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| self._filename, | ||
| "exec", | ||
| ) | ||
| self.compile(expression) |
There was a problem hiding this comment.
It's a bit of a shame that this won't validate whether the expression will run. For instance, it won't check that import module will work, because that relies on the builtin __import__ being there, and we purposefully remove it when we call exec.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8002 +/- ##
===========================================
- Coverage 92.45% 52.18% -40.28%
===========================================
Files 669 670 +1
Lines 32712 32813 +101
===========================================
- Hits 30245 17124 -13121
- Misses 2467 15689 +13222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
TODO: look into making a |
|
Note to self: pre-importing django models won't prevent access to other tenants' data, as you can do Model.objects.raw() and type whatever sql you'd like. |
365809f to
d2b4a1c
Compare
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ed79466 to
95f1a6b
Compare
284821a to
9a31fa7
Compare
df1815c to
2ebd1b7
Compare
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
2ebd1b7 to
efdecf9
Compare
Details
Very much a WIP, I've only tested it a bit, and it seems to work with our existing blueprints. It also throws errors when trying to import something. Haven't tested stuff like
open.We also probably need to come up with a list of stuff to import "by default". For now I have the following, feel free to edit this description to add more:
jsonyamlreChecklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)