Skip to content

blueprints: only watch for fs events we're interested in#7810

Merged
rissson merged 1 commit intomainfrom
blueprints-fs-events-filter
Feb 9, 2024
Merged

blueprints: only watch for fs events we're interested in#7810
rissson merged 1 commit intomainfrom
blueprints-fs-events-filter

Conversation

@rissson
Copy link
Member

@rissson rissson commented Dec 7, 2023

Details

I looked into this after #7025. Turns out we were not using the built-in features for filtering filesystem events. With this we would be.

Not tried out yet.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Dec 7, 2023
@rissson rissson requested a review from a team as a code owner December 7, 2023 07:35
@netlify
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 74ef629
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65c668ed8da4870007f722fe

@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (cef1d2d) 46.62% compared to head (c62843b) 92.46%.
Report is 46 commits behind head on main.

❗ Current head c62843b differs from pull request most recent head 74ef629. Consider uploading reports for the commit 74ef629 to get more accurate results

Files Patch % Lines
authentik/blueprints/v1/tasks.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7810       +/-   ##
===========================================
+ Coverage   46.62%   92.46%   +45.83%     
===========================================
  Files         626      588       -38     
  Lines       30996    29196     -1800     
===========================================
+ Hits        14451    26995    +12544     
+ Misses      16545     2201    -14344     
Flag Coverage Δ
e2e 49.33% <21.42%> (+4.62%) ⬆️
integration 25.92% <21.42%> (-0.07%) ⬇️
unit 89.72% <21.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson force-pushed the blueprints-fs-events-filter branch from 1a15060 to c62843b Compare December 7, 2023 08:27
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson force-pushed the blueprints-fs-events-filter branch from 7c14b6a to 74ef629 Compare February 9, 2024 18:03
@rissson rissson requested a review from BeryJu February 9, 2024 18:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-blueprints-fs-events-filter-1707503205-74ef629
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-blueprints-fs-events-filter-1707503205-74ef629-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-blueprints-fs-events-filter-1707503205-74ef629

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-blueprints-fs-events-filter-1707503205-74ef629-arm64

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson merged commit 1ef224f into main Feb 9, 2024
@rissson rissson deleted the blueprints-fs-events-filter branch February 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants