added user_agent to Failed Logins Events#7664
Closed
roney492 wants to merge 3 commits intogoauthentik:mainfrom
roney492:main
Closed
added user_agent to Failed Logins Events#7664roney492 wants to merge 3 commits intogoauthentik:mainfrom roney492:main
roney492 wants to merge 3 commits intogoauthentik:mainfrom
roney492:main
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7664 +/- ##
===========================================
- Coverage 92.60% 52.33% -40.27%
===========================================
Files 587 588 +1
Lines 29075 29152 +77
===========================================
- Hits 26925 15258 -11667
- Misses 2150 13894 +11744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for the PR! Including the user-agent makes sense, although imo it might as well be included in all events created from HTTP requests. For the Client IP, that is already included in events in a separate field ( |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including the User-Agent in failed login attempt logs improves security monitoring. It enables the identification of suspicious or potentially malicious login attempts originating from specific devices or browsers.