Skip to content

events: don't update internal service accounts unless needed (cherry-pick #7611)#7640

Merged
BeryJu merged 1 commit intoversion-2023.10from
cherry-pick-538b65-version-2023.10
Nov 20, 2023
Merged

events: don't update internal service accounts unless needed (cherry-pick #7611)#7640
BeryJu merged 1 commit intoversion-2023.10from
cherry-pick-538b65-version-2023.10

Conversation

@gcp-cherry-pick-bot
Copy link
Contributor

Cherry-picked events: stop spam (#7611)

  • events: don't log updates to internal service accounts

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • dont log reputation updates

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • don't actually ignore things, stop updating outpost user when not required

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • prevent updating internal service account users

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • fix setattr call

Signed-off-by: Jens Langhammer jens@goauthentik.io


Signed-off-by: Jens Langhammer jens@goauthentik.io

* events: don't log updates to internal service accounts

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* dont log reputation updates

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* don't actually ignore things, stop updating outpost user when not required

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* prevent updating internal service account users

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix setattr call

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner November 20, 2023 16:43
@netlify
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 1b3e8c5
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/655b8cbe52c0ba0008b2dff8
😎 Deploy Preview https://deploy-preview-7640--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 4 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a494c6b) 92.58% compared to head (1b3e8c5) 48.21%.

Files Patch % Lines
authentik/core/api/users.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           version-2023.10    #7640       +/-   ##
====================================================
- Coverage            92.58%   48.21%   -44.37%     
====================================================
  Files                  587      587               
  Lines                28915    28926       +11     
====================================================
- Hits                 26771    13947    -12824     
- Misses                2144    14979    +12835     
Flag Coverage Δ
e2e 46.58% <81.25%> (-4.37%) ⬇️
integration 26.03% <75.00%> (+0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 7c3d60e into version-2023.10 Nov 20, 2023
@BeryJu BeryJu deleted the cherry-pick-538b65-version-2023.10 branch November 20, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant