web/admin: fix html error on oauth2 provider page (cherry-pick #7384)#7424
Merged
BeryJu merged 1 commit intoversion-2023.10from Nov 3, 2023
Merged
web/admin: fix html error on oauth2 provider page (cherry-pick #7384)#7424BeryJu merged 1 commit intoversion-2023.10from
BeryJu merged 1 commit intoversion-2023.10from
Conversation
* web: break circular dependency between AKElement & Interface. This commit changes the way the root node of the web application shell is discovered by child components, such that the base class shared by both no longer results in a circular dependency between the two models. I've run this in isolation and have seen no failures of discovery; the identity token exists as soon as the Interface is constructed and is found by every item on the page. * web: fix broken typescript references This built... and then it didn't? Anyway, the current fix is to provide type information the AkInterface for the data that consumers require. * \# Details Extra `>` symbol screwed up the reading of the rest of the component. Unfortunately, too many fields in an input are optional, so it was easy for this bug to bypass any checks by the validators. I should have caught it myself, though.
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked web/admin: fix html error on oauth2 provider page (#7384)
This commit changes the way the root node of the web application shell is
discovered by child components, such that the base class shared by both
no longer results in a circular dependency between the two models.
I've run this in isolation and have seen no failures of discovery; the identity
token exists as soon as the Interface is constructed and is found by every item
on the page.
This built... and then it didn't? Anyway, the current fix is to
provide type information the AkInterface for the data that consumers
require.
Extra
>symbol screwed up the reading of the rest of the component. Unfortunately,too many fields in an input are optional, so it was easy for this bug to bypass any
checks by the validators. I should have caught it myself, though.