Skip to content

providers/oauth2: rework OAuth2 Provider#4652

Merged
BeryJu merged 22 commits intomainfrom
providers/oauth2/rework
Feb 9, 2023
Merged

providers/oauth2: rework OAuth2 Provider#4652
BeryJu merged 22 commits intomainfrom
providers/oauth2/rework

Conversation

@BeryJu
Copy link
Copy Markdown
Member

@BeryJu BeryJu commented Feb 9, 2023

closes #4191, fixes issues with offline_access

currently access tokens and refresh tokens share the same expiry which defeats the purpose of having two different kinds

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 9, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit c34ec18
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/63e52612d8bc260008600bc7
😎 Deploy Preview https://deploy-preview-4652--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from 5b3fd5a to 82afcfe Compare February 9, 2023 11:50
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2023

Codecov Report

Base: 93.07% // Head: 93.10% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (844d997) compared to base (1f88330).
Patch coverage: 92.98% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4652      +/-   ##
==========================================
+ Coverage   93.07%   93.10%   +0.04%     
==========================================
  Files         481      482       +1     
  Lines       24186    24240      +54     
==========================================
+ Hits        22509    22567      +58     
+ Misses       1677     1673       -4     
Flag Coverage Δ
e2e 53.77% <63.55%> (+0.01%) ⬆️
integration 26.86% <20.07%> (+0.02%) ⬆️
unit 89.76% <92.65%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/providers/oauth2/errors.py 79.77% <ø> (ø)
authentik/providers/oauth2/urls.py 100.00% <ø> (ø)
authentik/providers/oauth2/api/tokens.py 79.04% <71.43%> (-3.32%) ⬇️
authentik/providers/oauth2/id_token.py 86.21% <86.21%> (ø)
authentik/providers/oauth2/views/token.py 87.06% <92.86%> (+1.84%) ⬆️
authentik/providers/oauth2/views/authorize.py 84.57% <93.75%> (+0.11%) ⬆️
authentik/api/authentication.py 96.88% <100.00%> (ø)
authentik/api/tests/test_auth.py 100.00% <100.00%> (ø)
authentik/api/v3/urls.py 100.00% <100.00%> (ø)
authentik/providers/oauth2/api/providers.py 96.30% <100.00%> (-0.06%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from 6bf00fd to 93aafe1 Compare February 9, 2023 13:02
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from 93aafe1 to b895639 Compare February 9, 2023 13:03
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from a574edb to 0bc29f5 Compare February 9, 2023 14:46
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from 0bc29f5 to d61d0dc Compare February 9, 2023 14:49
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from 35cdd17 to c34ec18 Compare February 9, 2023 16:57
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/oauth2/rework branch from eaed322 to 9238540 Compare February 9, 2023 17:20
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit af43330 into main Feb 9, 2023
@BeryJu BeryJu deleted the providers/oauth2/rework branch February 9, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token endpoint returning wrong value for expires_in (from refresh token instead of access token)

1 participant