Skip to content

web/admin: bug: stage update forms not rendering, several modal form buttons missing (cherry-pick #20373 to version-2026.2)#20394

Merged
GirlBossRush merged 2 commits intoversion-2026.2from
cherry-pick/20373-to-version-2026.2
Feb 19, 2026
Merged

web/admin: bug: stage update forms not rendering, several modal form buttons missing (cherry-pick #20373 to version-2026.2)#20394
GirlBossRush merged 2 commits intoversion-2026.2from
cherry-pick/20373-to-version-2026.2

Conversation

@authentik-automation
Copy link
Contributor

Cherry-pick of #20373 to version-2026.2 branch.

Original PR: #20373
Original Author: @kensternberg-authentik
Cherry-picked commit: d3b69b2

…buttons missing (#20373)

## What

Names being passed to the browser were being incorrectly rendered. This commit updates the code in `StrictUnsafe` so that after the correct-use assertion is passed, the elementProperties are checked to see if the attribute has been named differently from the typed attribute field, and if so, retrieves the attribute name and passes it, rather than the field name, to the browser.

## Why

Since we have a lot of components with similar interfaces, it makes sense to try and check that they’re being used correctly and that the types associated with them are correct. Plus Lit, unlike React, doesn’t have a self-erasing syntax: every Lit element *is* an element, whereas JSX is an esoteric function call syntax that happens to look like XML. JavaScript templates aren’t as pretty as JSX, but they get the job done just as readily.

But in this case, cleverness bit us: we want to use the component’s JavaScript field names and types to validate that we’re using it correctly and passing the right types, but in the end we’re constructing a tag that will trigger the browser to construct the component and use it– and the field names don’t always correspond to the attribute name. Lit has a syntax for mapping the one to the other and stores it in the `elementProperties` field.

This code checks that, after we’ve determined the correct prefix for an property field that has been passed into the component, that we’ve also checked and extracted the correct *attribute name* for that property field. Most of the time it will be the same as the property field, but it muts always be checked.
@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 0bc1c08
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6995ef3861da000008febd5e
😎 Deploy Preview https://deploy-preview-20394--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 0bc1c08
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6995ef385f88f900085352ab
😎 Deploy Preview https://deploy-preview-20394--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.31%. Comparing base (0b5bac7) to head (adaee63).
⚠️ Report is 1 commits behind head on version-2026.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                Coverage Diff                 @@
##           version-2026.2   #20394      +/-   ##
==================================================
+ Coverage           93.08%   93.31%   +0.23%     
==================================================
  Files                 978      978              
  Lines               54599    54599              
==================================================
+ Hits                50821    50949     +128     
+ Misses               3778     3650     -128     
Flag Coverage Δ
conformance 37.73% <ø> (+<0.01%) ⬆️
e2e 43.60% <ø> (+0.61%) ⬆️
integration 22.55% <ø> (+<0.01%) ⬆️
unit 91.49% <ø> (ø)
unit-migrate 91.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-adaee638a38255fcfc57cdbdf2d783c686e8bec2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-adaee638a38255fcfc57cdbdf2d783c686e8bec2

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush self-requested a review February 18, 2026 17:55
@GirlBossRush
Copy link
Contributor

GirlBossRush commented Feb 18, 2026

Note to self: Cherry-pick #20396 into this before merging

@GirlBossRush GirlBossRush merged commit 6682a66 into version-2026.2 Feb 19, 2026
94 checks passed
@GirlBossRush GirlBossRush deleted the cherry-pick/20373-to-version-2026.2 branch February 19, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants