sources/oauth: Fix an issue where wechat may crash duing login. (cherry-pick #18973 to version-2025.12)#19854
Merged
dewi-tik merged 3 commits intoversion-2025.12from Jan 29, 2026
Conversation
* Fix an issue where wechat may crash duing login. The WeChatOAuth2Client.get_access_token method was defined with a signature that required redirect_uri and code arguments, but the generic OAuth callback handler calls this method without any arguments (expecting the client to retrieve them from the request context). I have fixed authentik/sources/oauth/types/wechat.py by: Updating get_access_token signature: It now accepts **request_kwargs instead of mandatory positional arguments, matching the base OAuth2Client . Retrieving code correctly: It now looks for code in the request parameters using self.get_request_arg, just like standard OAuth clients. Adding State Validation: I added self.check_application_state() to ensure the state parameter matches, preventing CSRF attacks. Improving Error Handling: Both get_access_token and get_profile_info now return None (or error dicts) instead of raising exceptions when API calls fail. This prevents the "Server Error" (500) crashes you were seeing and allows Authentik to handle login failures gracefully. Signed-off-by: Anduin Xue <anduin@aiursoft.com> * Update wechat.py Signed-off-by: Anduin Xue <anduin@aiursoft.com> * Update wechat.py Signed-off-by: Anduin Xue <anduin@aiursoft.com> * Remove unnecessary blank lines in wechat.py Signed-off-by: Anduin Xue <anduin@aiursoft.com> * Fix linting issues in wechat.py --------- Signed-off-by: Anduin Xue <anduin@aiursoft.com> Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
6 tasks
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dewi-tik
approved these changes
Jan 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version-2025.12 #19854 +/- ##
===================================================
- Coverage 93.26% 93.26% -0.01%
===================================================
Files 947 947
Lines 52356 52369 +13
===================================================
+ Hits 48831 48840 +9
- Misses 3525 3529 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
melizeche
approved these changes
Jan 29, 2026
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-0e3c8c27b01bb7366999160dc16f9a4e0523a1a6
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-0e3c8c27b01bb7366999160dc16f9a4e0523a1a6Afterwards, run the upgrade commands from the latest release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #18973 to
version-2025.12branch.Original PR: #18973
Original Author: @Anduin2017
Cherry-picked commit: e01d7f2