Skip to content

web/forms: fix forms not resetting state when modal closes (cherry-pick #19562 to version-2025.12)#19635

Merged
dominic-r merged 1 commit intoversion-2025.12from
cherry-pick/19562-to-version-2025.12
Jan 22, 2026
Merged

web/forms: fix forms not resetting state when modal closes (cherry-pick #19562 to version-2025.12)#19635
dominic-r merged 1 commit intoversion-2025.12from
cherry-pick/19562-to-version-2025.12

Conversation

@authentik-automation
Copy link
Contributor

@authentik-automation authentik-automation bot commented Jan 21, 2026

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit d605dba
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69725cc795cbac00084dd31a
😎 Deploy Preview https://deploy-preview-19635--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GirlBossRush GirlBossRush force-pushed the cherry-pick/19562-to-version-2025.12 branch from fdd55ac to 1425c4f Compare January 21, 2026 06:22
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.02%. Comparing base (bfcdc9e) to head (d605dba).
⚠️ Report is 1 commits behind head on version-2025.12.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           version-2025.12   #19635      +/-   ##
===================================================
- Coverage            92.96%   92.02%   -0.95%     
===================================================
  Files                  946      946              
  Lines                52299    52299              
===================================================
- Hits                 48622    48126     -496     
- Misses                3677     4173     +496     
Flag Coverage Δ
e2e 40.20% <ø> (-3.18%) ⬇️
integration ?
unit 60.56% <ø> (-31.00%) ⬇️
unit-migrate 91.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GirlBossRush GirlBossRush force-pushed the cherry-pick/19562-to-version-2025.12 branch 2 times, most recently from cc7d695 to f873b41 Compare January 21, 2026 06:42
@GirlBossRush GirlBossRush self-requested a review January 21, 2026 06:42
@GirlBossRush GirlBossRush self-assigned this Jan 21, 2026
@GirlBossRush GirlBossRush added this to the Release 2025.12.3 milestone Jan 21, 2026
@GirlBossRush GirlBossRush force-pushed the cherry-pick/19562-to-version-2025.12 branch from f873b41 to f6f4ce6 Compare January 21, 2026 06:46
@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit d605dba
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69725cc7d63b1800086caf49
😎 Deploy Preview https://deploy-preview-19635--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

* web/forms: fix forms not resetting state when modal closes

Overview:

Forms were not properly resetting their state when closing modals, which caused stale values to persist when reopening forms. This affected all forms with @State() decorated properties.

Testing:

1. Create any item (user, token, application, etc.), close modal
2. Click Create again, form should show default/empty values
3. Edit an item, cancel, click Create - form should be empty
4. Edit an item, cancel, edit same item - should show correct data

Motivation:

Form inputs retained values from previous create/edit operations.

* Fix linter errors, types.

* Add property accessors, types.

---------

Co-authored-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>
@GirlBossRush GirlBossRush force-pushed the cherry-pick/19562-to-version-2025.12 branch from 5781b86 to d605dba Compare January 22, 2026 17:22
@dominic-r dominic-r enabled auto-merge (squash) January 22, 2026 17:26
@dominic-r dominic-r merged commit dd2ad94 into version-2025.12 Jan 22, 2026
123 of 125 checks passed
@dominic-r dominic-r deleted the cherry-pick/19562-to-version-2025.12 branch January 22, 2026 18:41
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d605dba74402742d64e27abb7fd30f0f1525fb20
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d605dba74402742d64e27abb7fd30f0f1525fb20

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants