Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| this.#locale = event.detail.readyLocale; | ||
| this.#locale = formatAcceptLanguageHeader(event.detail.readyLocale); | ||
| }; | ||
|
|
||
| constructor(localeHint?: string) { | ||
| this.#locale = autoDetectLanguage(localeHint); | ||
| constructor(languageTagHint: Intl.UnicodeBCP47LocaleIdentifier) { | ||
| this.#locale = formatAcceptLanguageHeader(languageTagHint); |
There was a problem hiding this comment.
e.g.
accept-language: ja-JP, en-US;q=0.8, en;q=0.5, *;q=0.3
| export function renderLocaleDisplayNames( | ||
| entries: LocaleDisplay[], | ||
| activeLocaleTag: TargetLanguageTag | null, | ||
| export function formatRelativeLocaleDisplayName( | ||
| languageTag: TargetLanguageTag, | ||
| localizedDisplayName: string, | ||
| relativeDisplayName: string, | ||
| ) { |
There was a problem hiding this comment.
Split the render function from the formatter logic to re-use in the locale stage prompt component.
| * @param localeHint An optional locale code hint. | ||
| * @param fallbackLocaleCode An optional fallback locale code. | ||
| * @param languageTagHint An optional locale code hint. | ||
| * @param fallbackLanguageTag An optional fallback locale code. |
There was a problem hiding this comment.
Consistent usage of "language tag" (a string) vs locale (a JavaScript Locale object)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19229 +/- ##
==========================================
+ Coverage 93.12% 93.36% +0.24%
==========================================
Files 949 949
Lines 52419 52419
==========================================
+ Hits 48813 48942 +129
+ Misses 3606 3477 -129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
076db76 to
603aec0
Compare
| self.navigator?.language, | ||
| fallbackLocaleCode, | ||
| languageTagHint, | ||
| ...(self.navigator?.languages || []), |
There was a problem hiding this comment.
8430670 to
8635d44
Compare
| <path | ||
| d="M27.85 29H30l-6-15h-2.35l-6 15h2.15l1.6-4h6.85Zm-7.65-6 2.62-6.56L25.45 23ZM18 7V5h-7V2H9v3H2v2h10.74a14.7 14.7 0 0 1-3.19 6.18A13.5 13.5 0 0 1 7.26 9h-2.1a16.5 16.5 0 0 0 3 5.58A16.8 16.8 0 0 1 3 18l.75 1.86A18.5 18.5 0 0 0 9.53 16a16.9 16.9 0 0 0 5.76 3.84L16 18a14.5 14.5 0 0 1-5.12-3.37A17.64 17.64 0 0 0 14.8 7Z" | ||
| d="M16 2a14 14 0 1 0 14 14A14 14 0 0 0 16 2m12 13h-6a24.26 24.26 0 0 0-2.79-10.55A12 12 0 0 1 28 15M16 28a5 5 0 0 1-.67 0A21.85 21.85 0 0 1 12 17h8a21.85 21.85 0 0 1-3.3 11 5 5 0 0 1-.7 0m-4-13a21.85 21.85 0 0 1 3.3-11 6 6 0 0 1 1.34 0A21.85 21.85 0 0 1 20 15Zm.76-10.55A24.26 24.26 0 0 0 10 15H4a12 12 0 0 1 8.79-10.55ZM4.05 17h6a24.26 24.26 0 0 0 2.75 10.55A12 12 0 0 1 4.05 17m15.16 10.55A24.26 24.26 0 0 0 22 17h6a12 12 0 0 1-8.79 10.55" |
There was a problem hiding this comment.
follow up to UI feedback, swapping this to Carbon's globe icon.
| className?: string, | ||
| ): SlottedTemplateResult { | ||
| if (!imagePath) { | ||
| export const ThemedImage: LitFC<ThemedImageProps> = ({ src, className, theme, ...props }) => { |
There was a problem hiding this comment.
Reworked to usage of rootInterface, which may flicker or have stale values when the chosen color scheme changes.
8635d44 to
da8c4ba
Compare
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-8a64762dd62fc410384b322f2739b5836f26a635
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-8a64762dd62fc410384b322f2739b5836f26a635Afterwards, run the upgrade commands from the latest release notes. |
da8c4ba to
024def4
Compare
authentik translations instructionsThanks for your pull request! authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kensternberg-authentik
left a comment
There was a problem hiding this comment.
Needs to be broken up. :-)
|
Resolved in each separate PR. |
Details
How to review
This PR is split into separate topics to make the changes more digestable: