Skip to content

web: fix Open button selecting row instead of navigating (cherry-pick #18992 to version-2025.12)#19003

Merged
BeryJu merged 1 commit intoversion-2025.12from
cherry-pick/18992-to-version-2025.12
Dec 22, 2025
Merged

web: fix Open button selecting row instead of navigating (cherry-pick #18992 to version-2025.12)#19003
BeryJu merged 1 commit intoversion-2025.12from
cherry-pick/18992-to-version-2025.12

Conversation

@authentik-automation
Copy link
Contributor

Cherry-pick of #18992 to version-2025.12 branch.

Original PR: #18992
Original Author: @dominic-r
Cherry-picked commit: e3d774b

the `isEventTargetingListener()` function only checked the click target and the immediate parent for interactive elements (like links, buttons and more). when clicking the icon inside the Open button, the DOM structure is:

<a href=...>  <--- 2 levels up, never checked
<pf-tooltip>  <--- immediate parent, not interactive
<i> <---- click target, not interactive

Because <i> and <pf-tooltip> did not match the interactive elements query, the function returned false which caused the table rowClickListener to continue with row selection isntead of allowing the click.

The fix is to update the function to to traverse (up) the entire dom tree from the click target to the listener element (the table cell) and check for each ancestor for the interactive elements.
@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 1b824c7
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69494fc40ee6310008301f4c
😎 Deploy Preview https://deploy-preview-19003--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 1b824c7
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69494fc4eb11c000085405bf
😎 Deploy Preview https://deploy-preview-19003--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (80bcbe4) to head (1b824c7).
⚠️ Report is 4 commits behind head on version-2025.12.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           version-2025.12   #19003      +/-   ##
===================================================
+ Coverage            92.98%   93.22%   +0.24%     
===================================================
  Files                  946      946              
  Lines                51951    51951              
===================================================
+ Hits                 48305    48432     +127     
+ Misses                3646     3519     -127     
Flag Coverage Δ
e2e 44.76% <ø> (+0.63%) ⬆️
integration 23.26% <ø> (+<0.01%) ⬆️
unit 91.49% <ø> (+<0.01%) ⬆️
unit-migrate 91.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 24360bf into version-2025.12 Dec 22, 2025
79 of 86 checks passed
@BeryJu BeryJu deleted the cherry-pick/18992-to-version-2025.12 branch December 22, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants