Skip to content

web/i18n: Lit Locale Context#18424

Closed
GirlBossRush wants to merge 6 commits intomainfrom
locale-context
Closed

web/i18n: Lit Locale Context#18424
GirlBossRush wants to merge 6 commits intomainfrom
locale-context

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Nov 28, 2025

Details

This PR replaces <ak-locale-context> with a Lit Context, allowing for faster locale detection, reading of the current locale, and fewer re-renders between locale changes.

Related

@GirlBossRush GirlBossRush requested review from a team as code owners November 28, 2025 13:48
@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit dea6e5d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/692f071fb077850007f6304c
😎 Deploy Preview https://deploy-preview-18424--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit dea6e5d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/692f071fb077850007f6304e
😎 Deploy Preview https://deploy-preview-18424--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit dea6e5d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/692f071ff86db1000803710a
😎 Deploy Preview https://deploy-preview-18424--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (f914af7) to head (dea6e5d).
⚠️ Report is 20 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18424      +/-   ##
==========================================
+ Coverage   92.78%   93.03%   +0.25%     
==========================================
  Files         911      911              
  Lines       49848    49848              
==========================================
+ Hits        46250    46375     +125     
+ Misses       3598     3473     -125     
Flag Coverage Δ
e2e 45.24% <ø> (+0.66%) ⬆️
integration 22.88% <ø> (+<0.01%) ⬆️
unit 91.20% <ø> (+<0.01%) ⬆️
unit-migrate 91.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

Comment on lines -53 to -65
export function brand(): Promise<CurrentBrand> {
if (!globalBrandPromise) {
globalBrandPromise = new CoreApi(DEFAULT_CONFIG)
.coreBrandsCurrentRetrieve()
.then((brand) => {
brandSetFavicon(brand);
brandSetLocale(brand);
return brand;
});
}
return globalBrandPromise;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be unused for quite some time?

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Found a typo in a comment. :-)

// #region Attribute Observation

/**
* Synchronizes changes the document's `lang` attribute to the locale context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"changes to" or "changes in", no?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-dea6e5d81a0f42215cc0e81083f6d1645505e94f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-dea6e5d81a0f42215cc0e81083f6d1645505e94f

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush self-assigned this Dec 2, 2025
@GirlBossRush GirlBossRush added area:frontend Features or issues related to the browser, TypeScript, Node.js, etc i18n Internationalization and localization labels Dec 2, 2025
@GirlBossRush GirlBossRush added this to the Release 2025.12 milestone Dec 2, 2025
@GirlBossRush
Copy link
Contributor Author

Resolved via #18426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc i18n Internationalization and localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants