Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't happen to read the logs of this step, everything seems fine and
git checkout $(prev_stable)is just interpreted as the no-opgit checkout. That's because$()spawns a subshell and subshell errors don't stop execution onset -eo pipefail. In fact, a quick search didn't reveal any way to catch this typo withset.I wonder how long this could have stayed hidden if I wasn't specifically looking at this workflow for a completely different reason.