sources/sync: configuration for outgoing sync trigger mode#17669
sources/sync: configuration for outgoing sync trigger mode#17669
Conversation
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #17669 +/- ##
==========================================
+ Coverage 93.15% 93.20% +0.04%
==========================================
Files 944 945 +1
Lines 51664 51715 +51
==========================================
+ Hits 48130 48201 +71
+ Misses 3534 3514 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-e27f6a43106ee95b1df7f701d84174a2671cd236
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-e27f6a43106ee95b1df7f701d84174a2671cd236Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
kensternberg-authentik
left a comment
There was a problem hiding this comment.
Looks good. Having to use a function to pass options in should be optional, but I think that's on us (frontend), not Risson.
| import { customElement } from "lit/decorators.js"; | ||
| import { ifDefined } from "lit/directives/if-defined.js"; | ||
|
|
||
| function createSyncOutgoingTriggerModeOptions(): RadioOption<SyncOutgoingTriggerModeEnum>[] { |
There was a problem hiding this comment.
Nit: This is a static array. Why is it a function? If it has to be a function for API purposes, wrap it separately.
| if source.sync_outgoing_trigger_mode == SyncOutgoingTriggerMode.IMMEDIATE: | ||
| count = sync_inst.sync(page) | ||
| else: | ||
| with sync_outgoing_inhibit_dispatch(): |
There was a problem hiding this comment.
| with sync_outgoing_inhibit_dispatch(): | |
| with sync_outgoing_respect_inhibit_dispatch(source): |
Kinda on the fence imo, we could just pass the source into the context manager and let it decide what to do rather than having the same snippet everywhere
There was a problem hiding this comment.
The idea was that if we ever want to expand that for other places in the code, you can. But we can add an intermediate method for sources only that will look at the source to do so
There was a problem hiding this comment.
Although that comes with extra hurdles for the DEFERRED_END case
Details
Closes #17648
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)