Skip to content

web: Make Webdriver optional during install. (backport of #15952)#16458

Closed
authentik-automation[bot] wants to merge 6 commits intoversion-2025.4from
cherry-pick-15952-to-version-2025.4
Closed

web: Make Webdriver optional during install. (backport of #15952)#16458
authentik-automation[bot] wants to merge 6 commits intoversion-2025.4from
cherry-pick-15952-to-version-2025.4

Conversation

@authentik-automation
Copy link
Contributor

@authentik-automation authentik-automation bot commented Aug 28, 2025 •
edited by GirlBossRush
Loading

  • Move devDependencies into dependencies — avoids issues where GH actions that do not use npm ci --include=dev have missing deps
  • Bump ESBuild to latest 0.25 release. ESBuild’s sub-1.0.0 package allows any transitive dependency with a looser semver to upgrade to a later release, breaking our optionalDepedencies range
  • Move WDIO and chrome related packages into optionalDepedencies
  • Fix lock linter from reporting unresolved dependencies for other architectures

⚠️ This cherry-pick has conflicts that require manual resolution.

Cherry-pick of #15952 to version-2025.4 branch.

Original PR: #15952
Original Author: @GirlBossRush
Cherry-picked commit: de9b795

Please resolve the conflicts in this PR before merging.

@authentik-automation authentik-automation bot requested a review from a team as a code owner August 28, 2025 21:53
@authentik-automation authentik-automation bot mentioned this pull request Aug 28, 2025
Merged
6 tasks
@netlify
Copy link

netlify bot commented Aug 28, 2025 •
edited
Loading

❌ Deploy Preview for authentik-docs failed. Why did it fail? →

Name Link
🔨 Latest commit a126432
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68b58a01dd7c030008ddf6b2

@netlify
Copy link

netlify bot commented Aug 28, 2025 •
edited
Loading

❌ Deploy Preview for authentik-integrations failed. Why did it fail? →

Name Link
🔨 Latest commit a126432
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68b58a011a483a000882c5cc

@GirlBossRush @gergosimonyi
Cherry-pick #15952 to version-2025.4 (with conflicts)
308ce5b 
This cherry-pick has conflicts that need manual resolution.

Original PR: #15952
Original commit: de9b795
@gergosimonyi gergosimonyi force-pushed the cherry-pick-15952-to-version-2025.4 branch from 864f03e to 308ce5b Compare August 28, 2025 22:05
@codecov
Copy link

codecov bot commented Aug 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (dc91c8e) to head (a126432).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@                Coverage Diff                 @@
##           version-2025.4   #16458      +/-   ##
==================================================
- Coverage           92.77%   92.72%   -0.06%     
==================================================
  Files                 809      809              
  Lines               41555    41555              
==================================================
- Hits                38554    38530      -24     
- Misses               3001     3025      +24
Flag Coverage Δ
e2e 47.71% <ø> (-0.09%) ⬇️
integration 24.39% <ø> (ø)
unit 90.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gergosimonyi gergosimonyi force-pushed the cherry-pick-15952-to-version-2025.4 branch 2 times, most recently from 1e9101f to 4f2baab Compare August 29, 2025 11:37
@gergosimonyi gergosimonyi force-pushed the cherry-pick-15952-to-version-2025.4 branch from 4f2baab to 06981a3 Compare August 29, 2025 12:02
@BeryJu BeryJu closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GirlBossRush GirlBossRush GirlBossRush approved these changes

Assignees

No one assigned

Labels

cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GirlBossRush @BeryJu @gergosimonyi @dewi-tik