Skip to content

web: Form error rendering#15874

Merged
GirlBossRush merged 1 commit intomainfrom
snake-case-errors
Aug 7, 2025
Merged

web: Form error rendering#15874
GirlBossRush merged 1 commit intomainfrom
snake-case-errors

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Jul 30, 2025

This PR adjusts form and wizard error handling to use existing utilities for a more consistent rendering.

See also


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@GirlBossRush GirlBossRush requested a review from a team as a code owner July 30, 2025 00:20
@netlify
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 20cbc5a
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6894d5edefb6510008778dda

@netlify
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 20cbc5a
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6894d5ed62177e000842c059
😎 Deploy Preview https://deploy-preview-15874--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 20cbc5a
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6894d5ed5ab0d60008ee13e9
😎 Deploy Preview https://deploy-preview-15874--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (fa5e8f9) to head (20cbc5a).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15874      +/-   ##
==========================================
- Coverage   92.78%   92.73%   -0.05%     
==========================================
  Files         833      833              
  Lines       44870    44870              
==========================================
- Hits        41633    41612      -21     
- Misses       3237     3258      +21     
Flag Coverage Δ
e2e 46.58% <ø> (-0.08%) ⬇️
integration 23.67% <ø> (+<0.01%) ⬆️
unit 90.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-20cbc5a0db94e705031706a253e339ee2ab1539d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-20cbc5a0db94e705031706a253e339ee2ab1539d

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush mentioned this pull request Jul 30, 2025
6 tasks
@GirlBossRush GirlBossRush changed the title web: Use snake case helper in forms web: Form error rendering Jul 30, 2025
@GirlBossRush GirlBossRush force-pushed the snake-case-errors branch 2 times, most recently from b5e910c to ae62b79 Compare August 4, 2025 16:06
Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally sound, looks good, builds correctly. I do like much of the new error handling.

@GirlBossRush GirlBossRush merged commit 331732c into main Aug 7, 2025
108 checks passed
@GirlBossRush GirlBossRush deleted the snake-case-errors branch August 7, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants