Conversation
✅ Deploy Preview for authentik-docs canceled.
|
a2c27cb to
a0145c7
Compare
721ed97 to
295ddae
Compare
a0145c7 to
d5f3bb4
Compare
295ddae to
1b6f9f2
Compare
d5f3bb4 to
2e3cd09
Compare
1b6f9f2 to
c1fdcdf
Compare
c1fdcdf to
2f59a75
Compare
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14616 +/- ##
==========================================
+ Coverage 92.75% 92.77% +0.01%
==========================================
Files 814 814
Lines 41901 41901
==========================================
+ Hits 38867 38872 +5
+ Misses 3034 3029 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-caf671d7865402666224fd7b55230c9947a01ee4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-caf671d7865402666224fd7b55230c9947a01ee4Afterwards, run the upgrade commands from the latest release notes. |
kensternberg-authentik
left a comment
There was a problem hiding this comment.
This is actually very good. I would have Jens double check the FlowExecutor, just because I'm less familiar with it than I should be.
| } | ||
| this.flowSlug = this.brand.flowUserSettings; | ||
|
|
||
| if (!this.flowSlug) return; |
There was a problem hiding this comment.
Please, no. Naked if statements should be forbidden by Prettier.
| public brand!: CurrentBrand; | ||
|
|
||
| public get brandingTitle(): string { | ||
| return this.brand.brandingTitle || DefaultBrand.brandingTitle; |
There was a problem hiding this comment.
Would ?? make more sense here (and there, and there, too)?
77da31a to
2b233ec
Compare
web: Fix edgecase where flow does not have brand.
- Prep for Storybook fixes.
2b233ec to
35d4d0d
Compare
Details
This PR addresses a related category of issues surrounding Lit's context controllers.
this.addController, ensuring their host callbacks are invoked when changes occur.resulting in immediate access the context and fewer re-renders.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)