stages/identification: refresh captcha on failure (cherry-pick #13697)#13699
Merged
BeryJu merged 1 commit intoversion-2025.2from Mar 28, 2025
Merged
stages/identification: refresh captcha on failure (cherry-pick #13697)#13699BeryJu merged 1 commit intoversion-2025.2from
BeryJu merged 1 commit intoversion-2025.2from
Conversation
* refactor cleanup behavior after stage form submit * refresh captcha on failing Identification stage * Revert "stages/identification: check captcha after checking authentication (#13533)" This reverts commit b7beac6. Including a Captcha stage in an Identification stage is partially to prevent password spraying attacks. The reverted commit negated this feature to fix a UX bug. After 6fde42a9170, the functionality can now be reinstated. --------- Co-authored-by: Simonyi Gergő <gergo@goauthentik.io>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## version-2025.2 #13699 +/- ##
==================================================
- Coverage 92.72% 92.67% -0.06%
==================================================
Files 793 793
Lines 40334 40335 +1
==================================================
- Hits 37399 37379 -20
- Misses 2935 2956 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked stages/identification: refresh captcha on failure (#13697)
refactor cleanup behavior after stage form submit
refresh captcha on failing Identification stage
Revert "stages/identification: check captcha after checking authentication (stages/identification: check captcha after checking authentication #13533)"
This reverts commit b7beac6.
Including a Captcha stage in an Identification stage is partially to
prevent password spraying attacks. The reverted commit negated this
feature to fix a UX bug. After 6fde42a9170, the functionality can now be
reinstated.
Co-authored-by: Simonyi Gergő gergo@goauthentik.io