web/admin: fix display bug for assigned users in application bindings in the wizard (cherry-pick #13435)#13452
Merged
BeryJu merged 1 commit intoversion-2025.2from Mar 11, 2025
Conversation
… in the wizard (#13435) * web: Add InvalidationFlow to Radius Provider dialogues ## What - Bugfix: adds the InvalidationFlow to the Radius Provider dialogues - Repairs: `{"invalidation_flow":["This field is required."]}` message, which was *not* propagated to the Notification. - Nitpick: Pretties `?foo=${true}` expressions: `s/\?([^=]+)=\$\{true\}/\1/` ## Note Yes, I know I'm going to have to do more magic when we harmonize the forms, and no, I didn't add the Property Mappings to the wizard, and yes, I know I'm going to have pain with the *new* version of the wizard. But this is a serious bug; you can't make Radius servers with *either* of the current dialogues at the moment. * This (temporary) change is needed to prevent the unit tests from failing. \# What \# Why \# How \# Designs \# Test Steps \# Other Notes * Revert "This (temporary) change is needed to prevent the unit tests from failing." This reverts commit dddde09. * web/admin: fix display bug for assigned users in application bindings in the wizard ## What Modifies the type-of-binding detection algorithm to check if there's a user field and that it's a number. ## Why The original type-of-binding detector checked if the field was set and asserted that it was a string of at least one character. Unfortunately, this doesn't work for `user`, where the primary key is an integer. Changing the algorithm to "It's really a string with something in it, *or* it's a number," works. ## Testing - Ensure you have at least one user you can use, and that user has a username. - Navigate through the Application Wizard until you reach the binding page. - Create a user binding - See that the user shows up in the table.
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeryJu
approved these changes
Mar 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## version-2025.2 #13452 +/- ##
===============================================
Coverage 92.75% 92.76%
===============================================
Files 793 793
Lines 40285 40285
===============================================
+ Hits 37367 37370 +3
+ Misses 2918 2915 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked web/admin: fix display bug for assigned users in application bindings in the wizard (#13435)
What
{"invalidation_flow":["This field is required."]}message, which was not propagatedto the Notification.
?foo=${true}expressions:s/\?([^=]+)=\$\{true\}/\1/Note
Yes, I know I'm going to have to do more magic when we harmonize the forms, and no, I didn't add the
Property Mappings to the wizard, and yes, I know I'm going to have pain with the new version of
the wizard. But this is a serious bug; you can't make Radius servers with either of the current
dialogues at the moment.
# What
# Why
# How
# Designs
# Test Steps
# Other Notes
This reverts commit dddde09.
What
Modifies the type-of-binding detection algorithm to check if there's a user field and
that it's a number.
Why
The original type-of-binding detector checked if the field was set and asserted that it was a string
of at least one character. Unfortunately, this doesn't work for
user, where the primary key is aninteger. Changing the algorithm to "It's really a string with something in it, or it's a number,"
works.
Testing