providers/scim: add compatibility mode for AWS & Slack#13342
providers/scim: add compatibility mode for AWS & Slack#13342rissson merged 3 commits intogoauthentik:mainfrom
Conversation
AWS /ServiceProviderConfig query responds that it supports patch, but they only support patching a single group property. resolves goauthentik#12321
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This doesn't account for other AWS partitions which use a different domain. An option to manually override would be a more robust solution |
Please show the AWS docs that mention SCIM support for any other domain? I used the authoritative endpoint list here, and this regex matches every one listed https://docs.aws.amazon.com/general/latest/gr/sso.html#sso_region That being said AWS docs are often out of date so please feel free to submit a patch if you know better. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
|
I took the liberty of pushing a more generic solution. I haven't discussed this with the team prior to implementing, so no promises on those changes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13342 +/- ##
==========================================
- Coverage 92.75% 92.73% -0.02%
==========================================
Files 793 793
Lines 40352 40386 +34
==========================================
+ Hits 37429 37453 +24
- Misses 2923 2933 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
You are welcome and encouraged to take that liberty with any PR I send to you any time! It will probably be a long time before I get familiar with your coding standards. My PRs will just be ideas, and you are always welcome to improve them. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
|
@BeryJu any idea when this will ship? |
|
With the next release. We don't publicly announce release dates in advance. |
|
It looks like this didn't make it in 2025.2.3, do you think you'll include it in the next release? |
|
Yes, this will be included in 2025.4 |
|
thanks! I know you don't publish dates, but do you have an approximate ETA? (and will you be skipping 2025.3?) |
|
no guarantees, but we've been sticking to a rough every-two-months schedule lately and intend that with this next major release later in April |
|
it seemes not to be shipped with 2025.2.4 |
|
Will be shipped with 2025.4 |
Details
AWS /ServiceProviderConfig query responds that it supports patch, but they only support patching a single group property.
resolves #12321
Checklist
ak test authentik/)make lint-fix)