Skip to content

admin: clean up Recovery process by admin#13124

Closed
gergosimonyi wants to merge 1 commit intomainfrom
admin/add-explicit-token-expiry-modal
Closed

admin: clean up Recovery process by admin#13124
gergosimonyi wants to merge 1 commit intomainfrom
admin/add-explicit-token-expiry-modal

Conversation

@gergosimonyi
Copy link
Collaborator

@gergosimonyi gergosimonyi commented Feb 19, 2025

Details

Closes #9671
Closes #12445 (Therefore, in this regard supersedes #12591)


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit bb46027
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67b60df95509020008fca44d
😎 Deploy Preview https://deploy-preview-13124--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit bb46027
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67b60df9f767040008f76e68
😎 Deploy Preview https://deploy-preview-13124--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

❌ Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.55%. Comparing base (0ae373b) to head (bb46027).
⚠️ Report is 4213 commits behind head on main.

Files with missing lines Patch % Lines
authentik/core/api/users.py 22.22% 21 Missing ⚠️
authentik/stages/email/stage.py 72.72% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0ae373b) and HEAD (bb46027). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (0ae373b) HEAD (bb46027)
unit 9 7
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13124      +/-   ##
==========================================
- Coverage   92.71%   86.55%   -6.17%     
==========================================
  Files         792      792              
  Lines       40197    40232      +35     
==========================================
- Hits        37270    34824    -2446     
- Misses       2927     5408    +2481     
Flag Coverage Δ
e2e 48.10% <36.58%> (+<0.01%) ⬆️
integration 24.12% <21.95%> (-0.02%) ⬇️
unit 83.69% <41.46%> (-6.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gergosimonyi
Copy link
Collaborator Author

Done in #19875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression 2024.12 breaks recovery flow Recovery emails / links do not respect token_expiry

1 participant