Skip to content

sources: allow uuid or slug to be used for retrieving a source (2024.12 fix)#12772

Merged
BeryJu merged 1 commit intoversion-2024.12from
sources/fix-source-retrieve-slug
Jan 23, 2025
Merged

sources: allow uuid or slug to be used for retrieving a source (2024.12 fix)#12772
BeryJu merged 1 commit intoversion-2024.12from
sources/fix-source-retrieve-slug

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 22, 2025

Details

closes #12646

this is a separate fix for 2024.12.x to fix this behaviour without changing the API


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners January 22, 2025 23:09
@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 17a054b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67917a9187bcf300086952c3
😎 Deploy Preview https://deploy-preview-12772--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 5b02c3c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67921b460456630008899550
😎 Deploy Preview https://deploy-preview-12772--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (4b14eca) to head (5b02c3c).
Report is 1 commits behind head on version-2024.12.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/lib/api.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           version-2024.12   #12772      +/-   ##
===================================================
- Coverage            92.78%   92.73%   -0.06%     
===================================================
  Files                  770      771       +1     
  Lines                38797    38835      +38     
===================================================
+ Hits                 35999    36012      +13     
- Misses                2798     2823      +25     
Flag Coverage Δ
e2e 48.60% <65.90%> (-0.09%) ⬇️
integration 24.58% <0.00%> (-0.03%) ⬇️
unit 90.40% <97.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu changed the base branch from main to version-2024.12 January 23, 2025 10:32
@BeryJu BeryJu requested review from a team as code owners January 23, 2025 10:32
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/fix-source-retrieve-slug branch from 17a054b to 5b02c3c Compare January 23, 2025 10:34
@BeryJu BeryJu removed request for a team January 23, 2025 10:35
@BeryJu BeryJu changed the title sources: allow uuid or slug to be used for retrieving a source sources: allow uuid or slug to be used for retrieving a source (2024.12 fix) Jan 23, 2025
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-5b02c3c89666097cd5f759d70c29584faed3bb30
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-5b02c3c89666097cd5f759d70c29584faed3bb30

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit bccfb0b into version-2024.12 Jan 23, 2025
@BeryJu BeryJu deleted the sources/fix-source-retrieve-slug branch January 23, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create OIDC provider in version 2024.12.2

2 participants