Skip to content

core: add None check to a device's extra_description (cherry-pick #11904)#11906

Merged
BeryJu merged 1 commit intoversion-2024.10from
cherry-pick-19e702-version-2024.10
Nov 4, 2024
Merged

core: add None check to a device's extra_description (cherry-pick #11904)#11906
BeryJu merged 1 commit intoversion-2024.10from
cherry-pick-19e702-version-2024.10

Conversation

@gcp-cherry-pick-bot
Copy link
Contributor

Cherry-picked core: add None check to a device's extra_description (#11904)

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner November 4, 2024 17:10
@BeryJu BeryJu merged commit 510fecc into version-2024.10 Nov 4, 2024
@BeryJu BeryJu deleted the cherry-pick-19e702-version-2024.10 branch November 4, 2024 17:12
@netlify
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 74648df
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6728fff4617aaf0008b351b8
😎 Deploy Preview https://deploy-preview-11906--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (364a9a1) to head (74648df).
Report is 1 commits behind head on version-2024.10.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/api/devices.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-2024.10   #11906   +/-   ##
================================================
  Coverage            92.62%   92.63%           
================================================
  Files                  760      760           
  Lines                37793    37794    +1     
================================================
+ Hits                 35007    35009    +2     
+ Misses                2786     2785    -1     
Flag Coverage Δ
e2e 49.23% <50.00%> (+<0.01%) ⬆️
integration 24.93% <0.00%> (-0.01%) ⬇️
unit 90.14% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-74648df78615830288590f7de06f87421e9facbf
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-74648df78615830288590f7de06f87421e9facbf-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-74648df78615830288590f7de06f87421e9facbf

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-74648df78615830288590f7de06f87421e9facbf-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants