Skip to content

website/integrations: add MeshCentral#10490

Closed
axemann wants to merge 12 commits intogoauthentik:mainfrom
axemann:main
Closed

website/integrations: add MeshCentral#10490
axemann wants to merge 12 commits intogoauthentik:mainfrom
axemann:main

Conversation

@axemann
Copy link

@axemann axemann commented Jul 13, 2024

Details

This PR adds documentation for integrating authentik with MeshCentral.

No API or frontend changes have been made.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@axemann axemann requested a review from a team as a code owner July 13, 2024 17:08
@netlify
Copy link

netlify bot commented Jul 13, 2024 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 0ccd07e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/669d1e16f3b5d80008dbcca1
😎 Deploy Preview https://deploy-preview-10490--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2024 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 0ccd07e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/669d1e16197ff60008684a1d
😎 Deploy Preview https://deploy-preview-10490--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dominic-r
dominic-r requested changes Jul 13, 2024
View reviewed changes
website/integrations/services/meshcentral/index.md

## MeshCentral configuration

Edit the `config.json` for your MeshCentral deployment, and add the following code in the `domains:` subsection:
Copy link
Member

@dominic-r dominic-r Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add where the config json is located? if needed

@rissson rissson changed the title Add MeshCentral Integration docs website/integrations: add MeshCentral Jul 15, 2024
axemann and others added 3 commits July 16, 2024 13:48
@axemann @dominic-r
Update website/integrations/services/meshcentral/index.md
ea95c7d 
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann @dominic-r
Update website/integrations/services/meshcentral/index.md
3bd8d91 
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann @dominic-r
Update website/integrations/services/meshcentral/index.md
e6a65f6 
Co-authored-by: 4d62 <github-user@sdko.org>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (fd1d252) to head (0ccd07e).
Report is 1182 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10490      +/-   ##
==========================================
- Coverage   92.61%   92.60%   -0.01%     
==========================================
  Files         714      714              
  Lines       35010    35010              
==========================================
- Hits        32423    32422       -1     
- Misses       2587     2588       +1
Flag Coverage Δ
e2e 49.58% <ø> (-0.01%) ⬇️
integration 25.36% <ø> (ø)
unit 90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominic-r
Copy link
Member

dominic-r commented Jul 17, 2024

could you also switch out the > to use docsaurrus' warning / error boxes

tanberry
tanberry requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tanberry tanberry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @axemann for this contribution. MeshCentral looks kinda cool! I have a couple of nits and suggestions. Also, I noticed that the build check for prettier failed.. can you run make website or npm run prettier and then push to the PR again? Let me know if you have any questions; here are our docs for how to run the required linting before pushing a PR. https://docs.goauthentik.io/developer-docs/docs/writing-documentation

axemann and others added 6 commits July 21, 2024 09:39
@axemann @tanberry
Update website/integrations/services/meshcentral/index.md
09c84d6 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann @tanberry
Update website/integrations/services/meshcentral/index.md
0a39385 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann @tanberry
Update website/integrations/services/meshcentral/index.md
4fd18af 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann @tanberry
Update website/integrations/services/meshcentral/index.md
ed7cb12 
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: axemann <17078534+axemann@users.noreply.github.com>
@axemann
Linting
44a226b
@axemann
Add location for config.json in Docker deployments
785bf0e
@axemann axemann requested a review from tanberry July 21, 2024 14:18
@tanberry
Copy link
Contributor

tanberry commented Jul 31, 2024

Hi @axemann it seems the prettier-check is still failing... were you able to run the formatting command make website before pushing the latest commits? If you are doing this work in a local repo, that's this easiest way. Or are you doing this via the GitHub UI?

@dominic-r dominic-r mentioned this pull request Dec 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominic-r dominic-r dominic-r requested changes

@tanberry tanberry Awaiting requested review from tanberry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axemann @dominic-r @tanberry