This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Allow to get source position of unmarshal error#760
Closed
rhysd wants to merge 2 commits intogo-yaml:v3from
Closed
Allow to get source position of unmarshal error#760rhysd wants to merge 2 commits intogo-yaml:v3from
rhysd wants to merge 2 commits intogo-yaml:v3from
Conversation
|
It would be absolutely fantastic to have this capability. /cc @niemeyer is this blocked in any way? Could a small sponsoring help to move this forward? |
|
@rhysd I think there is a second case that's not handled. When Does |
This was referenced Sep 18, 2022
Author
|
It would be necessary. But I don't have enough time to update this branch for now. |
|
@rhysd Maybe you could take a look- forked your PR and added terminal failures with line numbers. |
Author
|
Looks good to me. Thank you for improving this branch. I'm closing this in favor of #901. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #759
With this PR, error instances in
TypeError.Errorsknow their source positions. Previously the field was string slice, but now it is slice of struct of message, line and column so that the caller can know where each error occurred exactly.