fix: skip DeletionPolicy removal for non-updatable stack statuses#607
Merged
fix: skip DeletionPolicy removal for non-updatable stack statuses#607
Conversation
Previously, RemoveDeletionPolicy only skipped ROLLBACK_COMPLETE stacks. Stacks in other non-updatable states (e.g. DELETE_FAILED, ROLLBACK_FAILED) would fail with an UpdateStack API error. Use a positive list of updatable statuses instead, and log a warning when skipping so users are aware that Retain resources may not be cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoveDeletionPolicyto only executeUpdateStackfor stacks in updatable statuses using a positive list approach-foption on stacks in non-updatable states such asDELETE_FAILEDBackground
When trying to delete a stack in
DELETE_FAILEDstate withdelstack -f, theUpdateStackAPI returned aValidationErrorand failed.Previously, only
ROLLBACK_COMPLETEwas skipped, but sinceUpdateStackis only allowed for a limited set of statuses, we now define updatable statuses (CREATE_COMPLETE,UPDATE_COMPLETE,UPDATE_ROLLBACK_COMPLETE,IMPORT_COMPLETE,IMPORT_ROLLBACK_COMPLETE) as a positive list.