feat: display and force-delete TerminationProtection stacks with -f flag#582
Merged
feat: display and force-delete TerminationProtection stacks with -f flag#582
Conversation
- Add DisableTerminationProtection client method using UpdateTerminationProtection API - Add forceMode to OperatorFactory and CloudFormationStackOperator for nested stack propagation - In -i mode with -f: show TP stacks with "* " prefix marker in selection list - In -i mode without -f: hide TP stacks (existing behavior) - In -s mode with -f: disable TP and proceed with deletion after confirmation prompt - In -s mode without -f: return TerminationProtectionError (existing behavior) - Add confirmation prompt before disabling TerminationProtection - Add Aurora DBCluster to testdata_deletion_protection CDK stack - Add -t/--no-tp flag to testdata deploy.go for toggling stack TerminationProtection - Update README with TerminationProtection documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #493
*prefix marker in-imode when-fis specified; prompt for confirmation, then disable TP and delete-smode with-f, prompt for confirmation, then disable TP and delete-f, maintain existing behavior: hide TP stacks in-imode, returnTerminationProtectionErrorin-smodeDisableTerminationProtectionclient method usingUpdateTerminationProtectionAPIforceModethroughOperatorFactory→CloudFormationStackOperator→ nested stacks-t/--no-tpflag to testdata deploy.go for toggling stack TerminationProtection