Fix handling of CLI provided global vars. #2288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2025
Member
|
Thanks for the PR! I'am going to merge the other one because it does not deep copy and locks vars |
Contributor
Author
|
@vmaerten I don't need credit. Thanks for getting to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CLI provided global vars are provided, they are placed in
e.Taskfile.Varsafter the global vars from the Taskfile. As a result, global vars defined in the Taskfile cannot reference those provided at the CLI. This PR changes the order that those CLI provided global vars are merged intoe.Taskfile.Varsbut/and retains priority for the CLI provided global vars.fixes #1580
fixes #1565 (probably)
fixes #2090
fixes #1108
may also partly resolve #2063