Truncate internal buffer when rows.Close() is called#904
Truncate internal buffer when rows.Close() is called#904methane wants to merge 2 commits intogo-sql-driver:masterfrom
Conversation
DoctorQ
left a comment
There was a problem hiding this comment.
I run this changes in my project!it's ok and fixed my problem
|
If I understand golang/go#23519 correctly, the issue is not that buffers can not be reused at all, but that it isn't safe to do so until the next |
buffer exposed by
I agree, but this is caused by adding context support. |
|
@julienschmidt Please reconsider #905 again. Currently, there is really race when context is cancelled. Race condition is one of most horrible thing in Go. If we don't fix it soon, we should notice this bug and say "You must not cancel the context passed to |
Description
Fixes #903
Checklist