Skip to content

buffer: Improve len(buf)==cap(buf) consistency#892

Closed
methane wants to merge 2 commits intogo-sql-driver:masterfrom
methane:buffer
Closed

buffer: Improve len(buf)==cap(buf) consistency#892
methane wants to merge 2 commits intogo-sql-driver:masterfrom
methane:buffer

Conversation

@methane
Copy link
Copy Markdown
Member

@methane methane commented Nov 13, 2018 •
edited
Loading

Description

Fix writeExecutePacket may set buf such that len(buf) < cap(buf).
And buffer.go keeps len(b.buf) == cap(b.buf) more explicitly.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane methane changed the title buffer: Improve cap consistency. buffer: Improve cap(buf) consistency Nov 13, 2018
@methane methane changed the title buffer: Improve cap(buf) consistency buffer: Improve len(buf)==cap(buf) consistency Nov 13, 2018
@methane methane mentioned this pull request Nov 13, 2018
Merged
5 tasks
@methane methane closed this Nov 16, 2018
@methane methane deleted the buffer branch November 16, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@methane