Conversation
cee8f7d to
ab5118f
Compare
|
I don't like registry. |
|
It's consistent with the existing code and we still support Go versions that do not support the Connector interface. Even with the Connector interface it is still useful to be able to serialize a config to a DSN string. That is only possible if the keys etc are addressable by an identifier. |
|
OK. But I don't want to use DSN and registry anymore.
|
|
That would require more changes to properly handle configurations that cannot be formatted as a DSN. |
|
Using a config to format a DSN is by the way currently its only usage. I don't plan to add support for the Connector interface before the 1.4.0 release. This will require a few more thoughts and changes as well as proper testing for which we don't have time if the 1.4.0 release should happen soon. Currently a config would thus be unusable as soon as someone adds a |
|
Then, how about |
|
It isn't a path but an identifier (name) for a registered key. |
methane
left a comment
There was a problem hiding this comment.
OK. While I think registries are ugly workaround for DSN limitation, we can't deprecate it yet...
Description
Fixes #625
It also adds the ability for
caching_sha2_passwordauthentication to use a local copy of the servers pub key.This PR depends on #807, which has to be merged first (This PR will then be rebased and the changeset will be a lot smaller)Checklist