Exec() now supports reporting results for multiple statements in a request (#1261)#1263
Closed
mherr-google wants to merge 0 commit intogo-sql-driver:masterfrom
Closed
Exec() now supports reporting results for multiple statements in a request (#1261)#1263mherr-google wants to merge 0 commit intogo-sql-driver:masterfrom
mherr-google wants to merge 0 commit intogo-sql-driver:masterfrom
Conversation
|
There is a memory loitering issue associated with this change. Details in this closed issue: github.com//issues/1304. I have a fix that should join this PR before it is merged. mherr-google@ please contact me. |
Contributor
Author
|
The memory loitering issue described in #1304 is fixed, this is now ready for review. |
5 tasks
Contributor
Author
|
This is superceded by #1309, which is the final version of the change being used internally (revised to address memory loitering). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exec() now provides access to the last inserted ID and number of affected rows for all statements, not just the last one. This is useful to execute batches of statements such as UPDATE with minimal roundtrips. Fixes #1261.
The approach taken is to track last insert id and affected rows using []int64 instead of a int64. Both are set in
mysqlResult, and a newmysql.Resultinterface makes them accessible to callers callingExec()viasql.Conn.Raw. For example:Checklist