Skip to content

utils: performance improvement for parseDateTime#1117

Closed
chanxuehong wants to merge 1 commit intogo-sql-driver:masterfrom
chanxuehong:master
Closed

utils: performance improvement for parseDateTime#1117
chanxuehong wants to merge 1 commit intogo-sql-driver:masterfrom
chanxuehong:master

Conversation

@chanxuehong
Copy link
Copy Markdown
Contributor

@chanxuehong chanxuehong commented May 30, 2020 •
edited
Loading

Description

I optimized the performance of parseDateTime in the PR #1098.

Now I find that parseDateTime can still be optimized. The implementation of this version is like parseBinaryDateTime, see

mysql/utils.go

Line 126 in 096feaa

func parseBinaryDateTime(num uint64, data []byte, loc *time.Location) (driver.Value, error) { 

Before:
BenchmarkParseDateTime-8   	 5117752	       235 ns/op
Now:
BenchmarkParseDateTime-8   	16154996	        74.8 ns/op

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@chanxuehong
Copy link
Copy Markdown
Contributor Author

chanxuehong commented May 30, 2020

I just saw #1113, please ignore this PR

@chanxuehong chanxuehong reopened this May 30, 2020
@chanxuehong chanxuehong mentioned this pull request May 30, 2020
Merged
5 tasks
@julienschmidt julienschmidt changed the title feat: performance improvement for parseDateTime performance improvement for parseDateTime May 31, 2020
@julienschmidt julienschmidt changed the title performance improvement for parseDateTime utils: performance improvement for parseDateTime May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chanxuehong @julienschmidt