Refactor: add a private constructor for connector#1115
Closed
dolmen wants to merge 1 commit intogo-sql-driver:masterfrom
Closed
Refactor: add a private constructor for connector#1115dolmen wants to merge 1 commit intogo-sql-driver:masterfrom
dolmen wants to merge 1 commit intogo-sql-driver:masterfrom
Conversation
This will allow to prepare more things in the constructor and do less on each Connect.
5 tasks
Member
|
The change as it currently is, is a bit useless. |
Contributor
Author
|
I agree this minor refactoring is a "a bit useless", but at least it should not be controversial and is a good base for further changes (which might be more controversial and might require multiple tries that would all start with this change). |
Member
|
And there is nothing wrong with including this very minor change in the maybe controversial change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a minor refactoring that will allow to prepare more things when the
Connectoris created and do less on eachConnect. Those changes will be proposed in further PRs (spoil: I intend to move some code fromhandleParamsonce #1111 is merged).Checklist