feat: check whether structs within arrays/slices/maps implement a Marshaler interface#87
Merged
tmzane merged 3 commits intogo-simpler:mainfrom Apr 5, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 3 3
Lines 219 219
=======================================
Hits 174 174
Misses 32 32
Partials 13 13 ☔ View full report in Codecov by Sentry. |
tmzane
requested changes
Apr 5, 2024
tmzane
previously approved these changes
Apr 5, 2024
tmzane
approved these changes
Apr 5, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of interface checks only handles cases where the root type implements json.Marshal. If it does not, the type is "unpacked" to a raw struct type, which is then checked for json: tags.
This fails when the root type does not implement json.Unmarshal, but is a transparent container for a type that contains a json.Marshal; e.g.
[]MyTypeormap[string]MyTypewhereMyTypeimplementsjson.Marshal.