feat: check whether nested types implement a Marshaler interface#84
Merged
tmzane merged 1 commit intogo-simpler:mainfrom Mar 26, 2024
Merged
feat: check whether nested types implement a Marshaler interface#84tmzane merged 1 commit intogo-simpler:mainfrom
tmzane merged 1 commit intogo-simpler:mainfrom
Conversation
Previously, only the top-level type was checked whether it implemented one of the provided interfaces. Nested types were not checked. This leads to false positives, for example when one field is of a struct type implementing `json.Marshaller`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 76.05% 79.06% +3.01%
==========================================
Files 3 3
Lines 213 215 +2
==========================================
+ Hits 162 170 +8
+ Misses 36 32 -4
+ Partials 15 13 -2 ☔ View full report in Codecov by Sentry. |
tmzane
approved these changes
Mar 26, 2024
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only the top-level type was checked whether it implemented one of the provided interfaces. Nested types were not checked.
This leads to false positives, for example when one field is of a struct type implementing
json.Marshaller.