Skip to content

fix: do not report types implementing (Un)Marshaler#67

Merged
tmzane merged 8 commits intomainfrom
skip-marshaler
Oct 8, 2023
Merged

fix: do not report types implementing (Un)Marshaler#67
tmzane merged 8 commits intomainfrom
skip-marshaler

Conversation

@tmzane
Copy link
Copy Markdown
Member

@tmzane tmzane commented Oct 7, 2023

Fixes #64

@tmzane tmzane force-pushed the skip-marshaler branch 2 times, most recently from 838f381 to 799a478 Compare October 7, 2023 19:34
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (11f0e6c) 86.45% compared to head (9870045) 83.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   86.45%   83.54%   -2.91%     
==========================================
  Files           2        2              
  Lines         192      231      +39     
==========================================
+ Hits          166      193      +27     
- Misses         18       25       +7     
- Partials        8       13       +5     
Files Coverage Δ
musttag.go 86.29% <71.42%> (-4.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmzane tmzane merged commit 1105e1a into main Oct 8, 2023
@tmzane tmzane deleted the skip-marshaler branch October 8, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not complain about structs which implement json.Marshaler

1 participant