fix(yaml): add encoding.Text(Un)marshaler to the interface whitelist#119
Merged
tmzane merged 1 commit intogo-simpler:mainfrom Apr 24, 2025
Merged
Conversation
MarshalYaml/UnmarshalYaml if MarshalText/UnmarshalText is present
c0012b1 to
37cd81a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 73.87% 73.87%
=======================================
Files 3 3
Lines 222 222
=======================================
Hits 164 164
Misses 47 47
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmzane
approved these changes
Apr 24, 2025
Member
|
Oh, I forgot about these for the yaml package, thanks. I'll fix the linter check and then we can merge it. |
MarshalYaml/UnmarshalYaml if MarshalText/UnmarshalText is present…shalText/UnmarshalText is present.
37cd81a to
c5d339c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project,
musttagwas triggered for the structure implementingencoding.TextMarshaler/encoding.TextUnmarshalerinterfaces when working with YAML, which looks like an error.