Skip to content

Prototype: Add defaulter support#27

Merged
casualjim merged 1 commit intogo-openapi:masterfrom
sttts:sttts-defaults
Jul 5, 2017
Merged

Prototype: Add defaulter support#27
casualjim merged 1 commit intogo-openapi:masterfrom
sttts:sttts-defaults

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Jun 13, 2017

We plan to use go-openapi for CustomResourceDefinition validation in Kubernetes (compare kubernetes/community#708). For that will need support for default values. This is a prototype to integrate this into go-openapi.

@sttts sttts mentioned this pull request Jun 13, 2017
Merged
@casualjim
Copy link
Copy Markdown
Member

casualjim commented Jun 21, 2017 •
edited
Loading

I haven't forgotten this I've just been very busy with work stuff (ironically: related to kubernetes) and haven't have been able to properly grok this PR.
Will try to get to it in the next 10 days

@casualjim
Copy link
Copy Markdown
Member

casualjim commented Jul 2, 2017

could you update this?

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 3, 2017

@casualjim just returned from vacation today. Will update after having catched up with mails.

@sttts sttts force-pushed the sttts-defaults branch from 2640fcc to f358b0e Compare July 5, 2017 07:52
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Jul 5, 2017

@casualjim rebased and simplified a lot

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 5, 2017

Codecov Report

Merging #27 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   83.71%   84.03%   +0.31%     
==========================================
  Files          10       10              
  Lines        1363     1384      +21     
==========================================
+ Hits         1141     1163      +22     
+ Misses        182      180       -2     
- Partials       40       41       +1
Impacted Files Coverage Δ
schema.go 78.86% <ø> (-0.34%) ⬇️
schema_props.go 96.07% <100%> (+0.42%) ⬆️
object_validator.go 89.47% <100%> (-1.84%) ⬇️
result.go 95.83% <100%> (+18.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035dcd7...f358b0e. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 5, 2017 •
edited
Loading

Codecov Report

Merging #27 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   83.71%   84.03%   +0.31%     
==========================================
  Files          10       10              
  Lines        1363     1384      +21     
==========================================
+ Hits         1141     1163      +22     
+ Misses        182      180       -2     
- Partials       40       41       +1
Impacted Files Coverage Δ
schema.go 78.86% <ø> (-0.34%) ⬇️
object_validator.go 89.47% <100%> (-1.84%) ⬇️
result.go 95.83% <100%> (+18.05%) ⬆️
schema_props.go 96.07% <100%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035dcd7...f358b0e. Read the comment docs.

@casualjim casualjim merged commit 8a82927 into go-openapi:master Jul 5, 2017
@nikhita nikhita mentioned this pull request Sep 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casualjim casualjim casualjim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sttts @casualjim