Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-openapi/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.2
Choose a base ref
...
head repository: go-openapi/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.27.0
Choose a head ref
  • 12 commits
  • 33 files changed
  • 1 contributor

Commits on Dec 11, 2023

  1. test readability: refactored TLS tests

    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5e80a92 View commit details
    Browse the repository at this point in the history
  2. chore: relinted denco router (govet)

    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    248b38c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. ByteStream consumer can write to interface{}

    * fix(ByteStreamConsumer): may now write into an interface which
      underlying type is []byte or string.
    
    * feat(ByteStreamConsumer): added support to io.ReaderFrom, preferred
      over io.Writer if available
    * feat(ByteStreamProducer): added support to io.WriterTo, preferred
      over io.Reader if available
    
    * refact(ByteStreamProducer): removed redundant case "string" and preferred
      the more general reflected case (supports aliased strings)
    
    * test: refactored ByteStream tests
    * test: added benchmark for bytestream.Consume
    
    * fixes #167
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e9d312a View commit details
    Browse the repository at this point in the history
  2. feat: more options for UI middleware

    - refactored UI middleware
      * factorized chore middleware to remove duplicated code
      * factorized UI middleware options: to avoid breaking changes in the
        options types, there is a decode/encode to a common structure
      * added more options:
        * allows to fully customize the UI template
      * added more unit tests
    
    - Spec middleware: added support for optional SpecOption argument
      * allows to serve the spec from a custom path / document name
    
    - serving with or without trailing "/" (cf. issue #238)
      * replaced path.Join() by path.Clean(), which is the intended behavior
        (i.e. serve the path, irrespective of the presence of a trailing
        slash)
      * generalized this behavior to all UI and Spec middleware, not just
        swaggerUI
    
    - API Context:
      * exposed middleware to serve RapiDoc UI
      * allowed new UIOption (...UIOption) to the APIHandler, etc middleware
      * coordinated UI / Spec middleware to be consistent when non-default
        path/document URL is served
    
    * fixes #192
    * fixes #226
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fe71d27 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. test: fixed typos and confusing tests

    This is a follow-up on #273.
    
    I realized that a few typos escaped my review on docstrings
    and that some misnomers for variables in tests made the tests
    difficult to read (e.g. rdr for a Writer...).
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    442694d View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. chore: removed support for pre go1.8

    Now that the go.mod requirement is to support at least go1.19, we may
    remove support for older versions of go.
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    bca195f View commit details
    Browse the repository at this point in the history
  2. refactored debug logging

    * relinted debugLog as debugLogf
    * fixes #244 (use logger.Debugf rather than logger.Printf)
    * fixes #118 (added support for injectable logger in Context and DefaultRouter)
    * removed global debug logger
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0d66801 View commit details
    Browse the repository at this point in the history
  3. added some test assertions for debug mode

    Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
    fredbi committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d4904c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. updated go-openapi dependencies

    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bdf50bc View commit details
    Browse the repository at this point in the history
  2. fixed immediate timeout

    * fixes #126
    
    This PR implements the proposal N°1 exposed in issue #126:
    * if there is a non-zero timeout set with the request, we
      add this timeout to the operation context
    * applicable contexts are:
       runtime.Context -> operation.Context -> context.WithTimeout(t>0)
    * the actual behavior is determined by the shortest deadline set on those
      contexts
    
    * added unit tests to assert that the different contexts are formed
    correctly:
      * an operation with no context inherits from the runtime context
      * an operation with no timeout set (by context or parameter) defaults to 30s (default timeout)
      * when several timeouts are set, the shortest wins
      * an operation with no timeout in context and a 0 timeout param waits
    for ever (and not with immediate timeout)
    
    Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
    fredbi committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    552b300 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. feat: more capable csv consumer and producer

    This PR allows to use the CSV consumer and producer in a more versatile way.
    There is no breaking change to the interface.
    
    * fixes #263 (types built with an io.Reader should be able to produce
      CSV)
    
    * csv/consumer can now consume CSV into *csv.Writer, io.Writer, io.ReaderFrom,
      encoding.BinaryUnmarshaler
    * also supports the new CSVWriter interface, i.e. anything that can
      Write([]string) error like *csv.Writer
    * also supports pointers with underlying type *[][]string, *[]byte and *string, not just
      *[]byte
    
    * csv/producer can now produce CSV from *csv.Reader, io.Reader,
      io.WriterTo, encoding.BinaryMarshaler
    * also supports the new CSVReader interface, i.e. anything that can
      Read() ([]string, error) like *csv.Reader
    * also supports underlying types [][]string, []byte and string, not just
      []byte
    
    * CSVConsumer and CSVProducer now stream CSV records whenever possible,
    * like ByteStreamConsumer and Producer, added the CSVCloseStream()
      option
    
    * added support to (optionally) configure the CSV format with CSVOpts,
      using the options made available by the standard library
    
    * doc: documented the above in the exported func signatures
    * test: added full unit test of the CSVConsumer and Producer
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    cc8632e View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. fix(ci): muted warnings in CI runs due to cache conflicts

    Every time a job is posted, I receive false alarm failure notifications because of some cache conflict during the linting job.
    
    Reference: golangci/golangci-lint-action#807
    
    * ci: fixed code coverage on all sub packages
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    13c451f View commit details
    Browse the repository at this point in the history
Loading